Skip to content

Comments

fix: all-day events calculation#193

Open
mickeypause wants to merge 1 commit intohowljs:mainfrom
mickeypause:feat/fix-allday-events-calculation
Open

fix: all-day events calculation#193
mickeypause wants to merge 1 commit intohowljs:mainfrom
mickeypause:feat/fix-allday-events-calculation

Conversation

@mickeypause
Copy link

Improve all-day events calculation

Problem

When creating an all-day event that spans multiple months, the calendar does not correctly divide the event.

For example, an event starting on March 28, 2025, and ending on April 2, 2025, currently only appears from March 28 to March 30. However, it should also create a continuation from March 31 to April 2.

Behavior Comparison

❌ Current Behavior ✅ Expected Behavior
Incorrect Correct

Solution

Added a check to determine whether the event spans multiple weeks. If the start and end weeks differ, an additional event segment is created to ensure proper display across month boundaries.

@howljs
Copy link
Owner

howljs commented Mar 19, 2025

I am reviewing the pull request and comparing the changes before and after, but it seems there is no difference. I need more information to identify the issue more clearly

Screen.Recording.2025-03-19.at.02.34.13.mp4

@mickeypause
Copy link
Author

I am reviewing the pull request and comparing the changes before and after, but it seems there is no difference. I need more information to identify the issue more clearly

Screen.Recording.2025-03-19.at.02.34.13.mp4

Weird, maybe it's timezone-related. Here, I have an event from March 29 to April 4, using the London timezone, which switches to summer time on the last Sunday in March.

Here are the start and end times after applying the timezone:
"2025-03-28T00:00:00.000+02:00" → "2025-04-03T23:59:59.999+03:00"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants