Apurva Shukla- Module 5 by apurvaone · Pull Request #89 · hotwax/training-assignment

apurvaone · 2023-05-22T13:23:53Z

Completed: Module 5

Solved all 34 problems

Learnt the following things in the module about Jolt:

Json to Json conversion
Why Jolt
Operators (shift, default, remove, modify-default-beta, modify-overwrite-beta, cardinality, sort)
Wildcards (@,&,*,#,|)
Levels
Advantages and Disadvantages of Jolt

Nidhipal09 · 2023-06-06T05:31:12Z

Module 5/Problem 1/problem1.json

+            "address": "=concat(@(1,address.street),' ',@(1,address.city), ' ', @(1,address.state), ' ',@(1,address.zip))",
+            "fullname": "=concat(@(1,firstName),' ',@(1,lastName))"
+          },
+          "itemTemp": "@(1,items)"


It can be easily done without creating a duplicate of the 'items' list. Please optimize this.

Nidhipal09 · 2023-06-06T05:41:16Z

Module 5/Problem 5/problem5.json

+      "email": "email",
+      "address": {
+        "city": "city",
+        "zip": "zip"


Can we use & here for all RHS values?

Nidhipal09 · 2023-06-06T05:44:50Z

Module 5/Problem 6/problem6.json

+            "name": "[#2].Name",
+            "hobbies": {
+              "*": {
+                "name": "[#4].Hobbies"


& is preferred over # to define levels.

Nidhipal09 · 2023-06-06T05:54:53Z

Module 5/Problem 8/problem8.json

+      "employees": {
+        "[0]": {
+          "bonus": 1000,
+          "tempBonus": 1000


Can be optimized. No need to create a bonus duplicate.

Nidhipal09 · 2023-06-06T06:02:56Z

Module 5/Problem 10/problem10.json

+    "spec": {
+      "fullname": "=split(' ',@(2,name))",
+      "first_name": "=firstElement(@(2,fullname))",
+      "last_name": "=lastElement(@(2,fullname))",


It is giving the desired output but 2 is not the correct level here. Please check.

Nidhipal09 · 2023-06-06T06:09:00Z

Module 5/Problem 12/problem12.json

+      "employee": {
+        "name": "&",
+        "address": "&",
+        "phones": "&"


Please check the output.

Nidhipal09 · 2023-06-06T06:16:07Z

Module 5/Problem 14/problem14.json

+        "*": {
+          "id": "employees.[#2].&",
+          "name": "employees.[#2].&",
+          "department": "employees[#2].&",


The use of wildcards is recommended over manually writing fields. Need to correct this in many other places.

Nidhipal09 · 2023-06-06T06:28:05Z

Module 5/Problem 15/problem15.json

+    }
+  },
+  {
+    "operation": "sort"


No need to sort.

Nidhipal09 · 2023-06-06T07:06:27Z

Module 5/Problem 29/problem29.json

+    "spec": {
+      "*": "&",
+      "person-address": {
+        "*": "person-address-&"


Please reduce the number of operations.

Nidhipal09 · 2023-06-06T07:08:08Z

Module 5/Problem 30/problem30.json

+    "operation": "shift",
+    "spec": {
+      "employee": {
+        "name": "&",


Nidhipal09 · 2023-06-06T07:16:28Z

Module 5/Problem 33/problem33.json

+        "*": {
+          "id": "@(3,id)",
+          "hobby_name": "@(1,name)",
+          "hobby_level": "@(1,level)",


Can be more optimized. Please check.

Nidhipal09 · 2023-06-06T08:13:12Z

Module 5/Problem 27/problem27.json

+        "Country": "Canada"
+      },
+      "[2]": {
+        "Country": "NA"


Indexing is hard coded. Make sure your spec is always loosely written, so that even if there are more fields you don't have to change the approach.

Nidhipal09 · 2023-06-06T10:25:31Z

Module 5/Problem 8/problem8_b.json

+        },
+        "[2]": {
+          "bonus": 900,
+          "tempBonus": 900


In this, the bonus is related to the department in some way. You can add that approach also.

…artment wise

…yee'

apurvaone added 22 commits May 22, 2023 18:37

Solved all questions of Module 5

863e134

added the solution of Problem 14

bae17c7

Corrected Problem 1: concatination of firstName and lastName

d17576a

Corrected the output in Problem 16

d8058b2

Added the missing 'department' field in Problem 8

2e3b42b

Added the missing 'salary' field in Problem 8

b9f7c62

Added explanation.md file in problems 1-4

1ed18f6

Optimized the transformation of Problem 5

c7e3cbc

Added explanation.md file for Problem 5-6

f6863d9

Optimized the transformation of problem 7 and added explanation.md file

661c422

Corrected the mention of used operation in Problem 7

570afe6

Added another solution for Problem 8 Transformation

90d02c5

Added the explanation.md file for Problems 8-10

587c4c5

Added optimized solution for problem 11

17ecbc3

Added the explanation.md file for problem 11

8a9f4aa

Optimized the transformation spec of Problem 12

e1e9b35

Added the explanation.md file for problem 12-13

3847138

Corrected the spec of problem 14 to add the missing 'department' field

641c989

Added the explanation.md file for problems 14-25

3dcdb70

Optimized the transformation spec of Problem 26

26484cd

Added the explanation.md file for problems 26-34

69ddb4c

Added the missing 'totalPrice' field in problem 15

4af606c

Nidhipal09 reviewed Jun 6, 2023

View reviewed changes

Module 5/Problem 12/problem12.json Outdated

"employee": {

"name": "&",

"address": "&",

"phones": "&"

Copy link

Nidhipal09 Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the output.

Nidhipal09 reviewed Jun 6, 2023

View reviewed changes

Module 5/Problem 15/problem15.json Outdated

}

},

{

"operation": "sort"

Copy link

Nidhipal09 Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to sort.

Nidhipal09 reviewed Jun 6, 2023

View reviewed changes

Module 5/Problem 30/problem30.json Outdated

"operation": "shift",

"spec": {

"employee": {

"name": "&",

Copy link

Nidhipal09 Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect

Nidhipal09 reviewed Jun 6, 2023

View reviewed changes

apurvaone added 23 commits June 7, 2023 12:21

Resolved problem 8 issue: removed the usage of field 'tempBonus'

eab9b22

Added alternate solution in problem 8,assuming the bonus is given dep…

cf48fb1

…artment wise

Optimized Problem 5 spec:used '&' to access the keys of map

0b8aa2a

Corrected the level in problem 10

0b82846

Optimized problem 1: removed the usage of duplicate field 'itemsTemp'

276f9c3

Problem 12: Corrected the key of list 'phone' to 'phoneNumbers'

5a76e63

Optimized Problem 14 :used wildcard '&' to access the keys of map

8e5e059

Problem 15: Removed the operation 'sort'

731df98

Optimized Problem 29: Reduced no. of operation

dc110c5

Corrected Problem 30: Taken name field from 'person' insted of 'emplo…

615ad7c

…yee'

Optimized Problem 33: Reduced no. of operation

b5b38b8

Optimized Problem 27: Made the spec more dynamic,reduced operations

87113cc

Used '&' to naviagte on levels instead of '#' in Problem 6

c3540bb

Updated the explanation.md file for problem 1

009ceb1

Updated the explanation file for problem 5

23015c1

Updated the explanation file for problem 8

44c0cc1

Updated the explanation file for problem 10

51cd391

Updated the explanation file for problem 12

b01f32b

Updated the explanation file for problem 15

72efc66

Updated the explanation file for problem 29

4c9e232

Updated the explanation file for problem 30

fec0f1d

Updated the explanation file for problem 33

5cb15fe

Updated the explanation file for problem 27

6351102

Conversation

apurvaone commented May 22, 2023

Uh oh!

Nidhipal09 Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nidhipal09 Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nidhipal09 Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Nidhipal09 Jun 6, 2023 •

edited

Loading

Nidhipal09 Jun 6, 2023 •

edited

Loading

Nidhipal09 Jun 6, 2023 •

edited

Loading