feat(engine): add query result retention policy (#123)#125
Draft
shefeek-jinnah wants to merge 2 commits intomainfrom
Draft
feat(engine): add query result retention policy (#123)#125shefeek-jinnah wants to merge 2 commits intomainfrom
shefeek-jinnah wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ready/failed) older than a configurable retention periodresult_retention_days(default: 7, set to 0 to disable)Details
Complements the existing stale result cleanup worker (which marks stuck
pending/processingresults asfailed) with a second phase that garbage-collects terminal results after a retention window.RUNTIMEDB_ENGINE__RESULT_RETENTION_DAYSenv var orengine.result_retention_daysin configdelete_expired_resultsimplemented for Postgres (DELETE...RETURNING) and SQLite (SELECT+DELETE)RuntimeEngine, gracefully shut down during engine termination