feat(tracing): add instrumentation hooks to liquid-cache builder#101
Draft
anoop-narang wants to merge 2 commits intomainfrom
Draft
feat(tracing): add instrumentation hooks to liquid-cache builder#101anoop-narang wants to merge 2 commits intomainfrom
anoop-narang wants to merge 2 commits intomainfrom
Conversation
Rewrite LiquidCacheClientBuilder locally to support object store and session state mapper hooks, enabling instrumentation for the liquid-cache code path. The builder now wraps object stores with tracing and adds the datafusion-tracing physical optimizer rule via the new extension points.
Contributor
Author
|
/build |
|
🐳 Docker image built and pushed: |
…che path Object store I/O happens on the liquid-cache server, not the client, so client-side object store wrappers see no traffic. Remove the with_object_store_mapper hook and keep only the session state mapper for datafusion-tracing instrumentation.
Contributor
Author
|
/build |
|
🐳 Docker image built and pushed: |
Contributor
Author
|
Error1 Error2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite LiquidCacheClientBuilder locally to support object store and session state mapper hooks, enabling instrumentation for the liquid-cache code path. The builder now wraps object stores with tracing and adds the datafusion-tracing physical optimizer rule via the new extension points.