Add VStack renderable item culling tests #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
VStack/VerticalStackNodecorrectly culls children outside the visible bounds and still includes children that are visible due to anoffset.Description
Tests/ComposeUITests/ComposeNodes/VerticalStackNodeTests.swift:test_renderableItems_filtersOffscreenChildrenandtest_renderableItems_includesOffsetChildrenthat exerciserenderableItems(in:)behavior withLayerNodechildren.layout(containerSize:context:)on aVStackwith fixed child frames and then asserts the frames returned byrenderableItems(in:)match the expected visible items.Testing
Codex Task
Note
Adds targeted coverage for
VStackvisibility culling inrenderableItems(in:).test_renderableItems_filtersOffscreenChildrenandtest_renderableItems_includesOffsetChildreninTests/ComposeUITests/ComposeNodes/VerticalStackNodeTests.swiftrenderableItems(in:)returns only visibleLayerNodeitems, culling offscreen children and including children visible due to.offset(...)Written by Cursor Bugbot for commit a5d13e9. This will update automatically on new commits. Configure here.