Add Support for Public Key Pemfiles #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement issue 423 in rustls we want to read Public Keys from pemfiles. In this pull request this functionality is implemented.
The value type of
SubjectPublicKeyis apki_types::CertificateDerinstead ofSubjectPublicKeyInfoDer, initially I thought it would be more intuitive to usepki_types::SubjectPublicKeyInfoDerinstead ofCertificateDer. However, theClientCertVerifierandServerCertVerifiertraits inrustlsexpect aCertificateDerstruct so I stuck with that.I'm not sure if there is ever a scenario where we want to load multiple Public Keys at once. If not it is most likely better to change the
public_keysfunction into apublic_keyfunction and return anOption.