allowing multiple repo checks and push#1
Open
kdsbatra wants to merge 21 commits intohollisjamison:mainfrom
Open
allowing multiple repo checks and push#1kdsbatra wants to merge 21 commits intohollisjamison:mainfrom
kdsbatra wants to merge 21 commits intohollisjamison:mainfrom
Conversation
kdsbatra
commented
Jul 8, 2021
studentList.js
Outdated
| { github: "larocque-m", slack: "U01NECKHL4E" }, | ||
| { github: "markh82581", slack: "U01NMC0GUV9" }, | ||
| { github: "marnie-k", slack: "U01NMC0GUV9" }, | ||
| { github: "kdsbatra", slack: "U0246KNS2KB" }, |
Author
There was a problem hiding this comment.
maybe make this part of git ignore? or have a file by bootcamp date/name?
kdsbatra
commented
Jul 8, 2021
| let { | ||
| repoDetails | ||
| } = require("./repos.js"); | ||
|
|
Author
There was a problem hiding this comment.
added repos as part of a new file instead of env file.
kdsbatra
commented
Jul 8, 2021
index.js
Outdated
| //const assignments = JSON.parse(dotenv.parse(Buffer.from(process.env.ASSIGNMENTS), opt)["REPOS"]); | ||
| const token = process.env.TOKEN; | ||
| const githubUser = process.env.USERNAME; | ||
| const githubUser = process.env.GITUSER; |
Author
There was a problem hiding this comment.
in windows this caused issues, so renamed the env variable.
kdsbatra
commented
Jul 8, 2021
index.js
Outdated
| } | ||
| console.log(`\x1b[31m ${student.github} has not made their '${repoName}' repo yet.` + (slackAlert ? ' Alert sent.' : '')); | ||
| if (failureCallBack) { | ||
| failureCallBack(); |
Author
There was a problem hiding this comment.
not used so can probably remove this failure callback.
kdsbatra
changed the title
Author
|
Readme.md file still to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.