React to 18 test - POC for using react-18 in ssg-hx-uk #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
putvande
reviewed
Apr 1, 2025
| "react-dom": "16.14.0", | ||
| "react-redux": "^5.0.6", | ||
| "redux": "^4.2.0", | ||
| "react": "18.2.0", |
There was a problem hiding this comment.
Any reason this hasn't gone to the last (stable) version 18? https://www.npmjs.com/package/react/v/18.3.1
putvande
reviewed
Apr 1, 2025
| console.log("Writing redirect to bash file for ".concat(pageUrl, " has failed."), err); | ||
| } | ||
| }; | ||
| var _default = exports.default = writeRedirect; No newline at end of file |
There was a problem hiding this comment.
Are all of these files supposed to be added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ssg-hx-uk is using the react version 16.8.1. This pr is to test the ssg-hx-uk on react version 18.
This is to move forward with technology and to enhance the performance of the application.
We have stumbled on few occasions when creating new search forms using vite etc we have to downgrade to use react 16 as ssg-hx-uk is using 16.
And to utilize the new features of react 18
ssg-toolbox - https://github.com/holidayextras/ssg-toolbox/pull/1038