Skip to content

Conversation

@jamie6king
Copy link
Contributor

What does this PR do? (please provide any background)

https://holidayextras.jira.com/browse/PD-47

  • Added lang prop documentation to all EU products (tested that the prop worked & correct lang was being passed back from the API).
    • The prop doesn't appear to be required and defaults to DE, so updated wording to reflect that. (although happy to be corrected here :) )
  • Added OpenSSL 1.1 install step as this not being installed caused weird errors when compiling dependencies.
  • Slightly tweaked the whitespace so the table is aligned again.

Any tech debt?

None.

Screenshots / Screencast

 2025-10-10 at 14 42 00

By approving a review you are confirming you have...

  • Witnessed the work behaving as expected (this could be on the author's machine or screencast).
  • Checked for coding anti-patterns.
  • Checked for appropriate test coverage.
  • Checked all the tests are passing.

@jamie6king jamie6king changed the title PD-47: add lang prop to booking request PD-47: add lang prop to booking request documentation Oct 10, 2025
@david-r-edgar
Copy link
Contributor

Actually we probably support pl too now? Might be worth updating all lists to include that?
(And ideally doing some tests too.)

@jamie6king
Copy link
Contributor Author

Actually we probably support pl too now? Might be worth updating all lists to include that? (And ideally doing some tests too.)

Just checked and yeah we do, added it to the list :)

(booking was successful with both a lounge & carpark)

@jamie6king jamie6king merged commit ab16aba into master Oct 14, 2025
4 checks passed
@jamie6king jamie6king deleted the PD-47 branch October 14, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants