Conversation
.atoum.php
Outdated
| $report = new Hoa\Test\Report\Cli\Cli(); | ||
| $runner->addReport($report->addWriter(new atoum\writers\std\out())); | ||
|
|
||
| // Add telemetry reporting |
There was a problem hiding this comment.
You can remove the comment, it's not really helpful :-].
|
Why is a WIP? What is missing? |
|
@jubianchi have talk about a specific extension for telemetry, The WIP is here to wait the new extension but if we keep this extension to use telemetry reporting everything is ok. |
|
OK, so we are waiting to change |
|
ping? |
|
What about now :-)? |
|
Good question. The telemetry report is not yet available in stand alone version. We need to wait to have this version in single mode or we can use the current version which include a part of other libraries but I think is not really painful. The main goal is to add tests un telemetry so we can addit like that for now and see what is happening after the separation. Thought ? |
|
|
|
@vonglasow https://github.com/atoum/telemetry-extension is here. Maybe @jubianchi can publish it on Packagist? |
ghost
assigned
|
@vonglasow https://packagist.org/packages/atoum/telemetry-extension it's ready :-)! |
|
yes, just need to remove the |
.atoum.php
Outdated
| $runner->addReport($coverallsReport); | ||
| } | ||
|
|
||
| $telemetry = new mageekguy\atoum\reports\telemetry(); |
There was a problem hiding this comment.
Use atoum directly (the alias is defined on top of the file).
.atoum.php
Outdated
|
|
||
| $telemetry = new mageekguy\atoum\reports\telemetry(); | ||
| $telemetry->readProjectNameFromComposerJson(__DIR__ . '/composer.json'); | ||
| $telemetry->addWriter(new mageekguy\atoum\writers\std\out()); |
.atoum.php
Outdated
| } | ||
|
|
||
| $telemetry = new mageekguy\atoum\reports\telemetry(); | ||
| $telemetry->readProjectNameFromComposerJson(__DIR__ . '/composer.json'); |
There was a problem hiding this comment.
Check the composer.json file exists before adding the extension.
|
oki I process your feedback during my lunch |
|
@Hywan to review and done. |
| $runner->addReport($coverallsReport); | ||
| } | ||
|
|
||
| if (file_exists($composerfile = __DIR__ . '/composer.json')) { |
There was a problem hiding this comment.
Do we want to always point to hoa/test?
2 participants
related to #62