ATED-1888 - added random and batch generator for AgentBusinessUtrs#25
Open
avinash-anand wants to merge 1 commit intohmrc:mainfrom
Open
ATED-1888 - added random and batch generator for AgentBusinessUtrs#25avinash-anand wants to merge 1 commit intohmrc:mainfrom
avinash-anand wants to merge 1 commit intohmrc:mainfrom
Conversation
|
I am not sure why this PR has been left open for half a year. @avinash-anand is this still of interest? The tax id generators will very likely get extracted into a separate library, but if you still want this to be merged, we could do that and then later move your code to that new lib. |
Author
|
@jh-hmrc - This PR was left maybe because GG team mentioned that domain is going to be deprecated or removed. But if merged, that would be of great value to us. And then whenever this is moved to some other lib, we can use the functions from there. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.