Add support for user impersonation, via admin #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbhavdal
reviewed
Oct 15, 2020
vbhavdal
reviewed
Oct 15, 2020
| @@ -0,0 +1,17 @@ | |||
| from django.contrib.auth import login | |||
Contributor
There was a problem hiding this comment.
This file, I would personally call it for example su.py.
hmpf
force-pushed
the
user-impersonation
branch
from
a08e9e7 to
4241885
Compare
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 56.01% 61.03% +5.01%
==========================================
Files 87 110 +23
Lines 6218 6721 +503
==========================================
+ Hits 3483 4102 +619
+ Misses 2735 2619 -116
Continue to review full report at Codecov.
|
hmpf
force-pushed
the
user-impersonation
branch
from
4241885 to
9cbf0aa
Compare
Owner
Author
|
The 3rd party library doesn't quite do what we need it to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds user impersonation with django-su. Unfortunately we need a feature that django-su doesn't have yet (different actions on impersonated login vs logout) so the code is stashed away here for the time being.