Skip to content

fix: streamline error logging structure in ErrorData and response pac… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmmftg merged 1 commit into from
Oct 27, 2025
Merged

fix: streamline error logging structure in ErrorData and response pac… #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions libError/errordata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,10 @@ func (e ErrorData) LogValue() slog.Value {
src = slog.Attr{}
}
return slog.GroupValue(
slog.Group("error",
slog.Time("time", e.Time),
slog.String("desc", e.ActionData.Description),
slog.Any("action", e.ActionData),
src,
slog.Any("child", e.Child),
),
slog.Time("time", e.Time),
slog.String("desc", e.ActionData.Description),
slog.Any("action", e.ActionData),
src,
slog.Any("child", e.Child),
)
}
12 changes: 5 additions & 7 deletions response/errorData.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,11 @@ func (e ErrorData) LogValue() slog.Value {
children = append(children, slog.Any(e.childs[id].GetDescription(), e.childs[id]))
}
return slog.GroupValue(
slog.Group("error",
slog.Int("status", e.Status),
slog.String("desc", e.Description),
slog.Any("message", e.Message),
slog.Any("source", e.source),
slog.Group("children", children...),
),
slog.Int("status", e.Status),
slog.String("desc", e.Description),
slog.Any("message", e.Message),
slog.Any("source", e.source),
slog.Group("children", children...),
)
}

Expand Down
5 changes: 3 additions & 2 deletions response/webHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package response

import (
"errors"
"fmt"
"log/slog"
"net/http"
"strings"
Expand Down Expand Up @@ -36,7 +37,7 @@ func getList(err error) []error {
func (m WebHanlder) errorhandler(w webFramework.WebFramework, err error) {
array := getList(err)
for id := range array {
webFramework.AddLogTag(w, webFramework.ErrorListLogTag, slog.Any(array[id].Error(), array[id]))
webFramework.AddLogTag(w, webFramework.ErrorListLogTag, slog.Any(fmt.Sprintf("error-%d", id), array[id]))
}
if newError := getError[libError.ErrorData](err); newError != nil {
m.Respond(newError.ActionData.Status.Int(), 1, newError.ActionData.Description, newError.ActionData.Message, true, w)
Expand All @@ -47,7 +48,7 @@ func (m WebHanlder) errorhandler(w webFramework.WebFramework, err error) {
return
}

webFramework.AddLogTag(w, webFramework.ErrorListLogTag, slog.Any(err.Error(), err))
webFramework.AddLogTag(w, webFramework.ErrorListLogTag, slog.Any("error", err))
desc := err.Error()
desc = strings.ToUpper(desc)
desc = strings.ReplaceAll(desc, " ", "")
Expand Down
Loading