Skip to content

Track layout #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Nrde wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Track layout #2

Nrde wants to merge 4 commits into from

Conversation

@Nrde
Copy link

@Nrde Nrde commented Feb 15, 2019

If track initially without extra layouts is modified or it gets additional layouts handle the original layout in it's main directory by adding virtual 'Default_layout' for it

  • detect tracks with originally only one layout, then add default_layout to their possible config for it
  • when getting track data remove default_layout from configs, and load it from original 'root' directory
  • adds change handler for configs so that ui_track.json gets loaded when config changes
  • moves tyre selection inside car selection column to prevent unneeded whites pace between them

Panu and others added 4 commits February 15, 2019 21:53
tracks initially without layouts will get 'default_layout'
97028f5
@Nrde
tyre form fields moved to same column with cars selection
07500f5 
- the space between between those fields was dependent on track selection columns height
@Nrde
removes dummy logging
cd9b474
@Nrde
fixes default layout handling in trackchanges
44759fb 
- fixes wrong track_configs when changing tracks
- fixes missing image when changing tracks when default_layout is chosen and track changes to one without default_layout
- move the logic to service
- only handle trackImage in controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Nrde