WAK-1758: Lakh ton is not working correctly #22
Conversation
tests/ParserTest.php
Outdated
| public function test_parses_dash_joined_unit_directly_if_registered() | ||
| { | ||
| $this->registry->register('watt-hour', new Unit( | ||
| // Watt |
There was a problem hiding this comment.
| // Watt | |
| // Watt |
tomhooijenga
left a comment
tomhooijenga
left a comment
There was a problem hiding this comment.
What happens when my unit-with-a-dash is part of some bigger unit? Like watt-hour/kg?
Cases:
|
src/Parser.php
Outdated
| 'value' => $match['unit'], | ||
| 'power' => (int)($match['power'] ?? 1), | ||
| ]; | ||
| // If the unit contains a dash, check if it's a registered unit as a whole |
There was a problem hiding this comment.
Out of interest, are there any units that actually have a dash but aren't compounds? Because that would completely ruin us right?
There was a problem hiding this comment.
It shouldn't be possible, but I guess we should be able to handle it. We do test for gram-liter and handle them individually for example
| ) | ||
| ); | ||
|
|
||
| static::registerSiUnit( |
There was a problem hiding this comment.
You should pull master.
|
|
||
| return new Unit(...array_merge([], ...$parts)); | ||
| } | ||
|
|
… as single unit, otherwise divide tokens
egedarici
force-pushed
the
WAK-1758-Lakh-ton-is-not-working-correctly
branch
from
92e9bda to
d9a31cb
Compare
egedarici
force-pushed
the
WAK-1758-Lakh-ton-is-not-working-correctly
branch
from
11317e5 to
7b0b58d
Compare
…s-not-working-correctly
Cases:
watt-hour)gram-literinto [gram,liter]/or*)watt-hour/kgor for examplegram-liter/hourwatt-hour/kgis tokenized into [watt-hour,/,kilogram] sincewatt-houris a registered single unitgram-liter/houris tokenized into [gram,liter,/,hour] sincegram-literis not a registered single unit and needs to be processed bygramandliter