-
Notifications
You must be signed in to change notification settings - Fork 4
Dev-newSNP #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hildebra
wants to merge
52
commits into
newSNP
Choose a base branch
from
dev
base: newSNP
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev-newSNP #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a script to download and format GTDB and GTDBtk databases, as well as to try to automatically udpate environment MGTKgtdbtk for different versions.
When concatenating parts of the GTDBtk database, the correct directory is now used. Created stub data (`helpers/install/get_gtdb`) for testing extraction logic. Use flag `--test` to use this stub data. Additionally fixed an error in arguments passed to `_processing_metadata` when downloading.
* scripts to autogenerate a QC report * changes to existing files to create the QC report * remove hardcoded path in QC_html_report.Rmd * Remove hardcoded path in QC_html_report.Rmd * The actual call was commented out in MG-TK.pl * bugs anthony noticed - coerce char type to num, some report looks weird
* GTDBtk v2.5 * remove mash, don't install tk default * fix(get_gtdb.py): remove mash for new versions, fix DBDir iterpolation, remove default GTDB-Tk install Newer versions of GTDB-Tk (>=2.5) do not use mash, so when configuring for this, comments out the GTDBtk_mash line in config_DBs.txt [DBDir] is now appropriately used in config, was previously not detected due to a newline character. No longer install GTDB-Tk by default, allow MG-TK to install based on environment yamls. Added --install-tk flag to install a version of GTDB-Tk which is compataible with the GTDB released being configured. --------- Co-authored-by: Falk Hildebrand <falk.hildebrand@gmail.com>
* scripts to autogenerate a QC report * changes to existing files to create the QC report * remove hardcoded path in QC_html_report.Rmd * Remove hardcoded path in QC_html_report.Rmd * The actual call was commented out in MG-TK.pl * bugs anthony noticed - coerce char type to num, some report looks weird
Co-authored-by: Falk Hildebrand <falk.hildebrand@gmail.com>
GTDBtk v2.5
Added new FAQ entries regarding MAG extraction and installation errors.
…the fly in parrallel, storage space reduced by gz_ing more files. rtk2 v2.14: clearer reports. vcf2fna v0.22: now also integrates INDELs. Installer will install newer versions of samtools, bcftools, strobealign, mmseqs2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.