Skip to content

chore: Edit .github/scripts/bot-assignment-check.sh so max assignment limit only applies to issues, it excludes PRs#1739

Open
AkshayKumarSahu wants to merge 3 commits intohiero-ledger:mainfrom
AkshayKumarSahu:1717
Open

chore: Edit .github/scripts/bot-assignment-check.sh so max assignment limit only applies to issues, it excludes PRs#1739
AkshayKumarSahu wants to merge 3 commits intohiero-ledger:mainfrom
AkshayKumarSahu:1717

Conversation

@AkshayKumarSahu
Copy link
Contributor

@AkshayKumarSahu AkshayKumarSahu commented Feb 7, 2026

Description:

Related issue(s):

Fixes #1717

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: AkshayKumarSahu <akshaykumar15031999@gmail.com>
Copilot AI review requested due to automatic review settings February 7, 2026 09:14
@AkshayKumarSahu AkshayKumarSahu requested review from a team as code owners February 7, 2026 09:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

Warning

Rate limit exceeded

@AkshayKumarSahu has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the assignment-limit guard script so the “max concurrent assignments” rule counts only issues, not pull requests—matching the intended workflow behavior from #1717.

Changes:

  • Adjust assignments_count() in the assignment-check bot script to exclude PRs from the open-assignment count.
  • Update bot limit-exceeded messages to clarify they apply to issue assignments.
  • Add a changelog entry describing the behavior change.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
CHANGELOG.md Documents the change that assignment limits now count only issues, not PRs.
.github/scripts/bot-assignment-check.sh Updates assignment counting logic and refines user-facing messaging around issue-only limits.
Comments suppressed due to low confidence (1)

.github/scripts/bot-assignment-check.sh:83

  • This message now says “1 open issue assignment”, but later in the same heredoc the restrictions list still says “Maximum 1 open assignment at a time”. Update the wording throughout this message to consistently refer to “issue assignments” (since PRs are no longer counted) to avoid confusing users.
Your account currently has limited assignment privileges with a maximum of **1 open issue assignment** at a time.

You currently have $count open issue(s) assigned.  Please complete and merge your existing assignment before requesting a new one.

**Current Restrictions:**

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>
@exploreriii exploreriii requested a review from a team February 7, 2026 09:39
@exploreriii exploreriii added the status: needs triage review PR needs a review from the triage team label Feb 7, 2026
@tech0priyanshu
Copy link
Contributor

hii @AkshayKumarSahu i would like to see test evidence

@tech0priyanshu tech0priyanshu added status: needs developer revision PR has requested changes that the developer needs to implement and removed status: needs triage review PR needs a review from the triage team labels Feb 7, 2026
@exploreriii
Copy link
Contributor

@tech0priyanshu could you specify pleae what that would involve, else could you test it please :)

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1739   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         141      141           
  Lines        9061     9061           
=======================================
  Hits         8450     8450           
  Misses        611      611           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AkshayKumarSahu
Copy link
Contributor Author

@tech0priyanshu
Screenshot 2026-02-07 at 4 40 38 PM
Attached SS of 3 diff profile which have issues assigned

@exploreriii
Copy link
Contributor

Request step security assistance @hiero-ledger/security-maintainers please

@tech0priyanshu
Copy link
Contributor

@AkshayKumarSahu fine lGTM

cc @exploreriii

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

Quick Fix for CHANGELOG.md Conflicts

If your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:

  1. Click on the "Resolve conflicts" button in the PR
  2. Accept both changes (keep both changelog entries)
  3. Click "Mark as resolved"
  4. Commit the merge

For all other merge conflicts, please read:

Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help needed: step security team status: needs developer revision PR has requested changes that the developer needs to implement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Beginner]: Edit .github/scripts/bot-assignment-check.sh so max assignment limit only applies to issues, it excludes PRs

3 participants