chore: format black tests/unit/crypto_utils_test.py#1738
chore: format black tests/unit/crypto_utils_test.py#1738exploreriii merged 6 commits intohiero-ledger:mainfrom
Conversation
Signed-off-by: AkshayKumarSahu <akshaykumar15031999@gmail.com>
Signed-off-by: AkshayKumarSahu <akshaykumar15031999@gmail.com>
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. Quick Fix for CHANGELOG.md ConflictsIf your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:
For all other merge conflicts, please read: Thank you for contributing! |
Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>
|
Caution Review failedAn error occurred during the review process. Please try again later. WalkthroughThe pull request applies black code formatter to standardize the style of the test file Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates formatting and documentation entries related to unit tests, with an additional (unrelated) API typing/docstring tweak in Transaction.to_bytes().
Changes:
- Reformat
tests/unit/crypto_utils_test.pyusing Black (line wrapping, quote style). - Add return type annotation and tweak docstring wording for
Transaction.to_bytes(). - Update
CHANGELOG.mdwith entries for the formatting change and theto_bytes()note.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/unit/crypto_utils_test.py |
Black formatting updates (line wrapping, string quoting). |
src/hiero_sdk_python/transaction/transaction.py |
Adds -> bytes return annotation and adjusts return docstring text for to_bytes(). |
CHANGELOG.md |
Adds/updates changelog bullets for the formatting change and to_bytes() (currently with placement/typo issues). |
Comments suppressed due to low confidence (2)
CHANGELOG.md:409
- This entry is being added under the already-released
0.1.8section. New changes should typically be recorded under[Unreleased](and only moved into a release section at release time). Please move this bullet to the appropriate[Unreleased]subsection and keep historical release notes immutable.
- Add Google-style docstrings to `AccountInfo` class and its methods in `account_info.py`.
- Added comprehensive Google-style docstrings to the `Logger` class and all utility functions in `src/hiero_sdk_python/logger/logger.py` (#639).
- add AccountRecordsQuery class
CHANGELOG.md:408
- The changelog text says the return of
to_bytes()was updated, but the code change here appears to be only a return type annotation/docstring tweak (no behavioral change). Please adjust the entry wording to reflect what actually changed, or drop the entry if it’s not a user-visible change.
- Added comprehensive Google-style docstrings to the `Logger` class and all utility functions in `src/hiero_sdk_python/logger/logger.py` (#639).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>
AkshayKumarSahu
left a comment
There was a problem hiding this comment.
pls review
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1738 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 141 141
Lines 9061 9061
=======================================
Hits 8450 8450
Misses 611 611 🚀 New features to boost your workflow:
|
|
Request step securtiy support please @hiero-ledger/security-maintainers |
I'm from mobile right now :(, I need to study the thing a bit more to resolve it, need a day to come back to my laptop🥲🥲 @exploreriii |
AntonioCeppellini
left a comment
There was a problem hiding this comment.
Thanks for your contribution @AkshayKumarSahu well done!
|
Thank you @AkshayKumarSahu and congratulations |
|
🎉 Nice work completing a Good First Issue! Thank you for your contribution to the Hiero Python SDK! We're excited to have you as part of our community. Here are some issues labeled Beginner you might be interested in working on next:
🌟 Stay connected with the project:
We look forward to seeing more contributions from you! If you have any questions, feel free to ask in our Discord community. From the Hiero Python SDK Team 🚀 |
Description:
Related issue(s):
Fixes #1524
Notes for reviewer:
Checklist