Skip to content

chore: format black tests/unit/crypto_utils_test.py#1738

Merged
exploreriii merged 6 commits intohiero-ledger:mainfrom
AkshayKumarSahu:1524
Feb 8, 2026
Merged

chore: format black tests/unit/crypto_utils_test.py#1738
exploreriii merged 6 commits intohiero-ledger:mainfrom
AkshayKumarSahu:1524

Conversation

@AkshayKumarSahu
Copy link
Contributor

@AkshayKumarSahu AkshayKumarSahu commented Feb 7, 2026

Description:

Related issue(s):

Fixes #1524

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: AkshayKumarSahu <akshaykumar15031999@gmail.com>
Signed-off-by: AkshayKumarSahu <akshaykumar15031999@gmail.com>
@AkshayKumarSahu AkshayKumarSahu requested a review from a team as a code owner February 7, 2026 08:49
Copilot AI review requested due to automatic review settings February 7, 2026 08:49
@AkshayKumarSahu AkshayKumarSahu requested a review from a team as a code owner February 7, 2026 08:49
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

Quick Fix for CHANGELOG.md Conflicts

If your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:

  1. Click on the "Resolve conflicts" button in the PR
  2. Accept both changes (keep both changelog entries)
  3. Click "Mark as resolved"
  4. Commit the merge

For all other merge conflicts, please read:

Thank you for contributing!

Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

The pull request applies black code formatter to standardize the style of the test file tests/unit/crypto_utils_test.py, with no functional or logical changes. A changelog entry was added to document this formatting update.

Changes

Cohort / File(s) Summary
Changelog Entry
CHANGELOG.md
Added release notes entry documenting the black formatting of the crypto_utils_test.py file.
Test File Formatting
tests/unit/crypto_utils_test.py
Applied black code formatter: string quotes standardized, assertion statements wrapped across multiple lines for readability. No logic or behavior changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: format black tests/unit/crypto_utils_test.py' directly and clearly summarizes the main change—formatting the crypto_utils_test.py file using Black.
Linked Issues check ✅ Passed The PR successfully implements the core requirement from issue #1524 by formatting tests/unit/crypto_utils_test.py with Black and includes a changelog entry.
Out of Scope Changes check ✅ Passed All changes are scoped to formatting tests/unit/crypto_utils_test.py and updating CHANGELOG.md, with no unrelated modifications present.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check ✅ Passed The PR description references issue #1524 which is about formatting tests/unit/crypto_utils_test.py using Black, matching the raw_summary and pr_objectives.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates formatting and documentation entries related to unit tests, with an additional (unrelated) API typing/docstring tweak in Transaction.to_bytes().

Changes:

  • Reformat tests/unit/crypto_utils_test.py using Black (line wrapping, quote style).
  • Add return type annotation and tweak docstring wording for Transaction.to_bytes().
  • Update CHANGELOG.md with entries for the formatting change and the to_bytes() note.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/unit/crypto_utils_test.py Black formatting updates (line wrapping, string quoting).
src/hiero_sdk_python/transaction/transaction.py Adds -> bytes return annotation and adjusts return docstring text for to_bytes().
CHANGELOG.md Adds/updates changelog bullets for the formatting change and to_bytes() (currently with placement/typo issues).
Comments suppressed due to low confidence (2)

CHANGELOG.md:409

  • This entry is being added under the already-released 0.1.8 section. New changes should typically be recorded under [Unreleased] (and only moved into a release section at release time). Please move this bullet to the appropriate [Unreleased] subsection and keep historical release notes immutable.
- Add Google-style docstrings to `AccountInfo` class and its methods in `account_info.py`.
- Added comprehensive Google-style docstrings to the `Logger` class and all utility functions in `src/hiero_sdk_python/logger/logger.py` (#639).
- add AccountRecordsQuery class

CHANGELOG.md:408

  • The changelog text says the return of to_bytes() was updated, but the code change here appears to be only a return type annotation/docstring tweak (no behavioral change). Please adjust the entry wording to reflect what actually changed, or drop the entry if it’s not a user-visible change.
- Added comprehensive Google-style docstrings to the `Logger` class and all utility functions in `src/hiero_sdk_python/logger/logger.py` (#639).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Akshay Kumar <akshaykumar15031999@gmail.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor Author

@AkshayKumarSahu AkshayKumarSahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls review

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1738   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         141      141           
  Lines        9061     9061           
=======================================
  Hits         8450     8450           
  Misses        611      611           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@exploreriii exploreriii requested a review from a team February 7, 2026 09:01
@exploreriii exploreriii added the status: needs triage review PR needs a review from the triage team label Feb 7, 2026
@exploreriii
Copy link
Contributor

Request step securtiy support please @hiero-ledger/security-maintainers

@AntonioCeppellini
Copy link
Member

Request step securtiy support please @hiero-ledger/security-maintainers

I'm from mobile right now :(, I need to study the thing a bit more to resolve it, need a day to come back to my laptop🥲🥲 @exploreriii

Copy link
Member

@AntonioCeppellini AntonioCeppellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @AkshayKumarSahu well done!

@exploreriii exploreriii merged commit 37a7742 into hiero-ledger:main Feb 8, 2026
19 checks passed
@exploreriii
Copy link
Contributor

Thank you @AkshayKumarSahu and congratulations

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

🎉 Nice work completing a Good First Issue!

Thank you for your contribution to the Hiero Python SDK! We're excited to have you as part of our community.

Here are some issues labeled Beginner you might be interested in working on next:

  1. [Beginner]: Update max assignments reached rejection message with more information

    🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level...

  2. [Beginner]: Edit .github/scripts/bot-assignment-check.sh so triage members max assignment is protected from being a mentor

    🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level...

  3. [Beginner]: Update .github/scripts/bot-inactivity-unassign.sh to skip if 'discussion' label is added

    🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level...

🌟 Stay connected with the project:

We look forward to seeing more contributions from you! If you have any questions, feel free to ask in our Discord community.

From the Hiero Python SDK Team 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: format black tests/unit/crypto_utils_test.py

3 participants