chore: fix broken training documentation links#1737
chore: fix broken training documentation links#1737ParasSalonia wants to merge 4 commits intohiero-ledger:mainfrom
Conversation
WalkthroughThis PR corrects broken documentation links in SDK developer training files (query and setup), updates several relative and external link targets, and adds a changelog "Fixed" entry documenting the documentation fixes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tech0priyanshu
left a comment
There was a problem hiding this comment.
Hi @ParasSalonia , thanks for the contribution! The link reference needs to be updated so that it redirects to the correct file.
Signed-off-by: ParasSalonia <parassalonia22@gmail.com>
45ff42a to
94d381d
Compare
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. Quick Fix for CHANGELOG.md ConflictsIf your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:
For all other merge conflicts, please read: Thank you for contributing! |
exploreriii
left a comment
There was a problem hiding this comment.
hi @ParasSalonia
This is great!
But your changelog has some mistakes
Please can you re-add line 253
https://github.com/hiero-ledger/hiero-sdk-python/pull/1737/changes
can you also delete the fixed section in line 255 as its duplicted
Then LGTM thank you
Signed-off-by: Paras Salonia <parassalonia22@gmail.com>
Updated maintainer guidelines and added new maintainer information. Signed-off-by: Paras Salonia <parassalonia22@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1737 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 141 141
Lines 9061 9061
=======================================
Hits 8450 8450
Misses 611 611 🚀 New features to boost your workflow:
|
Fixes #1707