Skip to content

ci: Non-blocking bot to remind about missing CHANGELOG entries#1734

Draft
parvninama wants to merge 5 commits intohiero-ledger:mainfrom
parvninama:fix/changelog-pr-comment
Draft

ci: Non-blocking bot to remind about missing CHANGELOG entries#1734
parvninama wants to merge 5 commits intohiero-ledger:mainfrom
parvninama:fix/changelog-pr-comment

Conversation

@parvninama
Copy link
Member

Changes

  • Extend the existing changelog check to post non-blocking PR comments when:
    - No CHANGELOG.md entry is added
    - Entries are added under a released version instead of [Unreleased]
  • Ensure comments are idempotent by avoiding duplicate bot messages on re-runs
  • Keep the existing changelog validation behavior unchanged (no new failing checks added)

Dry runs

  • in progress

Fixes [#1683]

Signed-off-by: Parv Ninama <ninamaparv@gmail.com>
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Hi @parvninama, this is **LinkBot** 👋

Linking pull requests to issues helps us significantly with reviewing pull requests and keeping the repository healthy.

🚨 This pull request does not have an issue linked.

Please link an issue using the following format:

📖 Guide:
docs/sdk_developers/how_to_link_issues.md

If no issue exists yet, please create one:
docs/sdk_developers/creating_issues.md

Thanks!

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1734   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         141      141           
  Lines        9061     9061           
=======================================
  Hits         8450     8450           
  Misses        611      611           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Updated comments for clarity and removed unused variable.

Signed-off-by: Parv <ninamaparv@gmail.com>
Removed redundant variable assignments for current_version.

Signed-off-by: Parv <ninamaparv@gmail.com>
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be a good idea to expand the current changelog script but currently I think the trigger for it in the workflow file requires maintainer approval
Which I think means the changelog entry won’t get a reminder until it’s probably already been manually pointed out

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

Quick Fix for CHANGELOG.md Conflicts

If your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:

  1. Click on the "Resolve conflicts" button in the PR
  2. Accept both changes (keep both changelog entries)
  3. Click "Mark as resolved"
  4. Commit the merge

For all other merge conflicts, please read:

Thank you for contributing!

@exploreriii exploreriii added the status: needs developer revision PR has requested changes that the developer needs to implement label Feb 7, 2026
@parvninama
Copy link
Member Author

It could be a good idea to expand the current changelog script but currently I think the trigger for it in the workflow file requires maintainer approval
Which I think means the changelog entry won’t get a reminder until it’s probably already been manually pointed out

Good point, thanks for highlighting this.
For now this builds on the existing workflow in a non-blocking way, but I agree the trigger timing is something we could improve later.

@exploreriii exploreriii added status: in initial development and removed status: needs developer revision PR has requested changes that the developer needs to implement labels Feb 7, 2026
Signed-off-by: Parv <ninamaparv@gmail.com>
@exploreriii
Copy link
Contributor

Hi @parvninama please let us know when this is ready to review again, and please do change the labels!

@parvninama
Copy link
Member Author

Hi @parvninama please let us know when this is ready to review again, and please do change the labels!

Thanks! I’ll update the labels and let you know once it’s ready for review again.

Signed-off-by: Parv <ninamaparv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants