ci: Non-blocking bot to remind about missing CHANGELOG entries#1734
ci: Non-blocking bot to remind about missing CHANGELOG entries#1734parvninama wants to merge 5 commits intohiero-ledger:mainfrom
Conversation
Signed-off-by: Parv Ninama <ninamaparv@gmail.com>
|
Hi @parvninama, this is **LinkBot** 👋
Linking pull requests to issues helps us significantly with reviewing pull requests and keeping the repository healthy. 🚨 This pull request does not have an issue linked. Please link an issue using the following format: 📖 Guide: If no issue exists yet, please create one: Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1734 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 141 141
Lines 9061 9061
=======================================
Hits 8450 8450
Misses 611 611 🚀 New features to boost your workflow:
|
Updated comments for clarity and removed unused variable. Signed-off-by: Parv <ninamaparv@gmail.com>
Removed redundant variable assignments for current_version. Signed-off-by: Parv <ninamaparv@gmail.com>
exploreriii
left a comment
There was a problem hiding this comment.
It could be a good idea to expand the current changelog script but currently I think the trigger for it in the workflow file requires maintainer approval
Which I think means the changelog entry won’t get a reminder until it’s probably already been manually pointed out
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. Quick Fix for CHANGELOG.md ConflictsIf your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:
For all other merge conflicts, please read: Thank you for contributing! |
Good point, thanks for highlighting this. |
Signed-off-by: Parv <ninamaparv@gmail.com>
|
Hi @parvninama please let us know when this is ready to review again, and please do change the labels! |
Thanks! I’ll update the labels and let you know once it’s ready for review again. |
Signed-off-by: Parv <ninamaparv@gmail.com>
Changes
- No CHANGELOG.md entry is added
- Entries are added under a released version instead of [Unreleased]
Dry runs
Fixes [#1683]