fix: redesign beginner issue template to improve completion rates#1729
fix: redesign beginner issue template to improve completion rates#1729cheese-cakee wants to merge 1 commit intohiero-ledger:mainfrom
Conversation
WalkthroughReworks the Beginner Issue GitHub template into a guidance-focused layout: updates intro wording and placement, renames several sections (e.g., Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CHANGELOG.md (1)
146-153:⚠️ Potential issue | 🟡 MinorDuplicate "### Changed" section headers under
[Unreleased].There are two
### Changedsections under[Unreleased]: one at line 146 (with this new entry) and another at line 153. This violates the Keep a Changelog format where each section type should appear only once per release version. The new entry should be moved to the existing### Changedsection starting at line 153.📝 Suggested fix to consolidate sections
Move line 147 to the existing
### Changedsection (after line 153) and remove the duplicate header:-### Changed -- Redesigned beginner issue template with readiness self-check, exploration-based task structure, compact workflow reference, and common pitfalls guidance to improve completion rates (`#1651`) - ### Documentation - Added comprehensive docstring to `compress_with_cryptography` function (`#1626`) - Replaced the docstring in `entity_id_helper.py` with one that is correct. (`#1623`) ### Changed +- Redesigned beginner issue template with readiness self-check, exploration-based task structure, compact workflow reference, and common pitfalls guidance to improve completion rates (`#1651`) - Updated return of to_bytes function in `src/hiero_sdk_python/transaction/transaction.py`. (`#1631`)
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1729 +/- ##
=======================================
Coverage 93.18% 93.18%
=======================================
Files 140 140
Lines 8977 8977
=======================================
Hits 8365 8365
Misses 612 612 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR redesigns the beginner issue template to address the lowest completion rate among all issue types. The redesign shifts from a detailed step-by-step tutorial approach to an exploration-based model that encourages independent problem-solving while providing appropriate safety rails.
Changes:
- Replaced prescriptive multi-section structure with a streamlined 4-field template focused on self-assessment and exploration
- Added readiness self-check criteria and common pitfall warnings based on real failure patterns
- Consolidated workflow guidance into a compact reference table with links instead of verbose checklists
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/ISSUE_TEMPLATE/03_beginner_issue.yml | Complete rewrite of beginner issue template with exploration-based structure, readiness checks, workflow quick-reference table, and practical pitfall warnings |
| CHANGELOG.md | Added entry documenting the template redesign under the Changed section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e9e11c6 to
b0da02f
Compare
|
ready for review ! @exploreriii @manishdait |
exploreriii
left a comment
There was a problem hiding this comment.
Super awesome @cheese-cakee
I think you are getting really close to hitting the bullseye
I have a couple doubts with no clear solution, what do you think?
| > - Work that requires deep knowledge across multiple areas of the codebase | ||
| ### Before you start 😊 | ||
|
|
||
| Beginner issues assume you have already completed a Good First Issue (or equivalent contribution). |
There was a problem hiding this comment.
I think one sticking point that the title 'Good First Issue' doesn't do a good job...
is that most new starters will probably find the best fit at doing a few GFI
I think we somehow need to make that clear without being rules or condescending and make it normal that most people will require a few GFI before moving on to a beginner issue
also begginner issues are always different, so, some might be a better fit than others and could be agood entry point
|
Hi @cheese-cakee also i don't know how this renders, so my ideas might not be right in terms of adding new sections etc |
|
thankyou for such detailed review @exploreriii . I am trying to incorporate your suggestions and merge it to my fork's main and see what works best. |
b0da02f to
e2c805e
Compare
ebb95b1 to
d49e297
Compare
Replaces the existing beginner issue template with a structurally distinct design focused on increasing completion rates. Key changes: - Readiness self-check so contributors can assess if they are ready - Single "The Task" section replaces the Description/Solution/Steps split - "Where to Start" exploration pointers replace step-by-step recipes - Compact workflow quick-reference table instead of full tutorial - Common pitfalls section addressing real failure patterns - External Python documentation references alongside project docs - All links converted to absolute URLs for correct issue rendering - AI guidance folded into pitfalls (no standalone section) Resolves: hiero-ledger#1651 Signed-off-by: cheese-cakee <farzanaman99@gmail.com>
d49e297 to
756c4ba
Compare
|
to check how it renders please click on this link: |
|
I'd like to see how it renders posted as well as to the issue creator, you may have to merge it to your main |
|
changed to draft please awaiting a final version of the published template 👍 |
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. Quick Fix for CHANGELOG.md ConflictsIf your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:
For all other merge conflicts, please read: Thank you for contributing! |
Summary
Redesigns the beginner issue template (
03_beginner_issue.yml) with a structurally distinct approach to address the lowest completion rate of any issue type.This is a fresh rewrite . The previous attempt (#1659) was closed after review feedback identified structural issues.
What changed
description:fields coaches maintainers on calibrating "slightly challenging"What was removed (intentionally)
Structural comparison
Resolves #1651