fix: skip inactivity close for PRs with discussion label

[shrav-jally]

Adds a check in bot-inactivity-unassign.sh to skip closing and unassigning pull requests that contain the discussion label.
This prevents valid PRs that are parked for discussion from being auto-closed by the inactivity bot.
Fixes #1583

[github-actions]

Hi @shrav-jally, this is **LinkBot** 👋

Linking pull requests to issues helps us significantly with reviewing pull requests and keeping the repository healthy.

🚨 This pull request does not have an issue linked.

Please link an issue using the following format:

• Fixes chore: [StepSecurity] Apply security best practices #123

📖 Guide:
docs/sdk_developers/how_to_link_issues.md

If no issue exists yet, please create one:
docs/sdk_developers/creating_issues.md

Thanks!

[Copilot]

Pull request overview

Updates the inactivity bot script to avoid auto-closing PRs that are intentionally paused for discussion by detecting a discussion label and skipping Phase 2 close/unassign actions for those PRs.

Changes:

• Added a discussion label check for linked PRs before performing inactivity close/unassign actions.
• Minor cleanup of inline comments and a small formatting tweak at the end of the script.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Walkthrough

A CHANGELOG entry is added documenting that the inactivity bot now skips closing pull requests labeled with discussion, preventing auto-closure of valid PRs awaiting discussion.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Added entry documenting that the inactivity bot now skips closing pull requests labeled discussion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check	❓ Inconclusive	The PR description and changes indicate the objective was to add a check in bot-inactivity-unassign.sh to detect and skip PRs with the 'discussion' label, and to include a changelog entry. However, the raw_summary shows only a CHANGELOG.md modification with no script changes visible, making it unclear if the core implementation requirement was fully met.	Verify that .github/scripts/bot-inactivity-unassign.sh was modified to include the label-detection logic and informative logging as specified in issue #1583.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a check to skip inactivity-triggered closure for PRs labeled with 'discussion'.
Description check	✅ Passed	The description is related to the changeset, explaining that a check was added to skip closing/unassigning PRs with the 'discussion' label and referencing the linked issue.
Out of Scope Changes check	✅ Passed	The raw_summary shows only CHANGELOG.md was modified, which aligns with the documented requirement to add a changelog entry. No extraneous changes are evident from the provided summary.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 3

[Akshat8510]

Hi @shrav-jally , Please add a line to CHANGELOG.md under the ### Changed. You can follow the guide here : https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/changelog_entry.md

[exploreriii]

Thank you @shrav-jally please add a changelog entry 👍

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

CHANGELOG.md (1)

138-144: ⚠️ Potential issue | 🟡 Minor

Duplicate "### Changed" section headers detected.

The [Unreleased] section contains two ### Changed headers (lines 138 and 144). According to Keep a Changelog format (which this project follows per line 5), each section type should appear only once per release. This duplication makes the changelog harder to parse and violates the standard format.

📝 Proposed fix: Consolidate into a single "### Changed" section

The solution is to merge all entries under a single ### Changed header. Since line 139 is the new entry being added, you should:

1. Remove the duplicate ### Changed header at line 144
2. Move all entries currently under the second ### Changed section to be under the first one (line 138)

This will create a single, consolidated ### Changed section that includes both the new inactivity bot entry and all existing changed items.

[coderabbitai]

Actionable comments posted: 1

[Akshat8510]

LGTM. Just fix the tiny spacing nit in the changelog and we’re good.

[shrav-jally]

Fixed the changelog spacing nit. Thanks!

[exploreriii]

This is great to go once the changelog is fixed! thank you

[github-actions]

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

Quick Fix for CHANGELOG.md Conflicts

If your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:

1. Click on the "Resolve conflicts" button in the PR
2. Accept both changes (keep both changelog entries)
3. Click "Mark as resolved"
4. Commit the merge

For all other merge conflicts, please read:

• Resolving Merge Conflicts
• Rebasing Guide

Thank you for contributing!

[aceppaluni]

@shrav-jally Thank you for your contribution!

If you have questions on the changelog let us know. We're happy to help!

[Akshat8510]

Hi @shrav-jally, it looks like something went wrong with the latest push. I noticed that the logic changes in .github/scripts/bot-inactivity-unassign.sh (the part that skips the 'discussion' label) have disappeared from the 'Files changed' tab.

[exploreriii]

Hi @shrav-jally
Apologies as pointed out by @Akshat8510 something is going wrong here
it appears you may have merging two PRs together, and in that processs, lost the original file changed that was relevant to the discussion issue

note here the PRs related to black formatting =/=discussion Prs

[exploreriii]

Hi @shrav-jally
Are you still planning on working on this issue?
Note we are unable to progress with your PR as it currently is a blank PR with just a changelog entry

[exploreriii]

Hi @shrav-jally
There has been no activity or updates on this PR for over a week, and it only includes a changelog entry, so I am closign this issue and freeing it up for others to take.
If you want to work on it, please do request to be assigned on the issue again
Thank you