jira feat: обновление структуры подсказок, новые методы поиска, обновления и создания задач #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ления и создания задач
Huskypug
reviewed
Jan 21, 2026
Contributor
There was a problem hiding this comment.
- На 27 строке MarshalJSON должен быть не указателем. На 35 у тебя уже правильно сделано
- формат времени можно в констатнту вынести
Huskypug
reviewed
Jan 21, 2026
| } | ||
| all = append(all, resp.Issues...) | ||
| offset += len(resp.Issues) | ||
| if len(resp.Issues) == 0 || offset >= resp.Total { |
Contributor
There was a problem hiding this comment.
ИМХО, чуть читаемее было бы сравнивать len(all) с resp.total и offset в конце обновлять
Huskypug
reviewed
Jan 21, 2026
jira/jira.go
Outdated
| availableStatuses[t.To.ID] = t.To.Name | ||
| if t.To.ID == targetStatusId { | ||
| targetTransitionID = t.ID | ||
| break |
Contributor
There was a problem hiding this comment.
- Не вижу смысла каждый раз делать мапу для ошибки. Более того в функцию formatAvailableStatuses без проблем можно передать слайс и сильно там логика не поменяется
- тут вместо break можно вызывать сразу return j.TransitionIssue(ctx, issueKey, targetTransitionID)
- В ИИ эти измненения строил и функция получается намного читаемее
Huskypug
reviewed
Jan 21, 2026
jira/templates.go
Outdated
| }, | ||
| } | ||
| } | ||
| var Issue = newIssueSug() |
Contributor
There was a problem hiding this comment.
Приписку Sug к названиям переменных нужно убрать везде
Huskypug
reviewed
Jan 21, 2026
jira/templates.go
Outdated
| EventType EventType // Тип события | ||
| } | ||
| type Issue struct { | ||
| type IssueSug struct { |
Contributor
There was a problem hiding this comment.
все внктренние структуры тут я бы от греха сделал неэкспортируемыми
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.