Open
Conversation
- Unify control logics in WinixDevice - Change WinixDevice as base class and new AirPurifierDevice class inheriting from it - Collect product_group during login
- dehumidifier: tested using the DWXE210 device - airconditioner: adeed dummy class as a placeholder
Currently, the Winix Smart app supports the following product groups: airpurifier, dehumidifier, and air conditioner. Updated the documentation to reflect this by generalizing descriptions, so that the application is not perceived as being limited to airpurifier device type.
- Add brigness sub-command - child_lock sub-command is already added for dehumidifier Derived from https://github.com/iprak/winix
6b1342d to
b75dc3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I recently purchased a Winix dehumidifier and came across your repository.
Thanks to winixctl, I was able to easily analyze the command codes for my device.
I truly appreciate your pioneering efforts in reverse engineering this.
Since the repository hasn't been updated for quite some time, I'm not sure if you're still maintaining it. If you don't have the time to review this, feel free to close the PR.
The main change in this PR is that it automatically selects the appropriate device class based on the product group information obtained during login.
There are a few caveats to note:
config.jsonfiles may not contain the product group information, which can lead to errors. You may need to delete the file and log-in again.winixctl log