Fix handling errors in generated topics.#121
Open
coreypobrien wants to merge 1 commit intoheynemann:masterfrom
Open
Fix handling errors in generated topics.#121coreypobrien wants to merge 1 commit intoheynemann:masterfrom
coreypobrien wants to merge 1 commit intoheynemann:masterfrom
Conversation
…es an error, fail the context and skip the vows as expected
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If generating a topic produces an error, fail the context and skip the vows as expected. Previously, this wouldn't be handled because _run_tests wasn't expected to generate a VowsTopicError. Moved generating the list of topics to _run_setup_and_topic. Someone will have to revisit this to be able to fix the issue mentioned in #57 where generated topics aren't started until after all of the topics are generated.