core: platform: Input callbacks, corrected framebuffer/window sizes, swapchain handling #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-transparent-window` example
… core has responsibility of swapchain
… triggered by pinch to zoom on a trackpad
…ndow.decoration_color`
Contributor
Author
|
Recent changes allow pinch to zoom and a new event to handle that. I also have picked up the change to |
Contributor
Author
|
|
…ar_input` events
…or command key blocking `keyUp` on other keys
…in and window/framebuffer sizes
foxnne
changed the title
…ndow size actually changed
Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
emidoots
reviewed
Dec 24, 2024
| core_window.width = width; | ||
| core_window.height = height; | ||
| core_window.framebuffer_width = width; | ||
| core_window.framebuffer_height = height; |
Member
There was a problem hiding this comment.
This is wrong / a bug - the window width/height should almost certainly not be the same as framebuffer_width/framebuffer_height.
emidoots
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires this mach-objc PR to be merged before we can update the zon for this one.