fix: Prevent empty values in PublicHome select filters#2
Merged
Conversation
This commit addresses an error where `Select.Item` components in the PublicHome page could receive an empty string as a value if a snippet's language or tag data contained an empty string. The `PublicHome.tsx` component has been updated to filter out any empty or whitespace-only strings from `snippet.language` or items in `snippet.tags` before adding them to the sets of available filter options. This ensures all `Select.Item` components receive valid, non-empty values, resolving the "A <Select.Item /> must have a value prop that is not an empty string" error. The `ALL_ITEMS_VALUE` constant (`_ALL_`) for the "All Languages" / "All Tags" options remains in place and functions as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses an error where
Select.Itemcomponents in the PublicHome page could receive an empty string as a value if a snippet's language or tag data contained an empty string.The
PublicHome.tsxcomponent has been updated to filter out any empty or whitespace-only strings fromsnippet.languageor items insnippet.tagsbefore adding them to the sets of available filter options. This ensures allSelect.Itemcomponents receive valid, non-empty values, resolving the "A <Select.Item /> must have a value prop that is not an empty string" error.The
ALL_ITEMS_VALUEconstant (_ALL_) for the "All Languages" / "All Tags" options remains in place and functions as intended.