Feature/album api (Refactored) #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not handling userId and only images yet. Without Tests
Post and Gets uses username as folder name now.
For now this class contains some temporary methods to create hard-coded Users.
SamuelLevi
requested changes
Apr 28, 2019
mugshot/src/main/java/hive/album/controller/UtilsController.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @ResponseStatus(code = HttpStatus.OK, reason = "Random image generated and successfully stored") | ||
| @PostMapping("/generateRandomImage") |
Contributor
There was a problem hiding this comment.
As it only has a verb of the type post
Suggested change
| @PostMapping("/generateRandomImage") | |
| @PostMapping |
| this.imageStorer=imageStorer; | ||
| } | ||
|
|
||
| @ResponseStatus(code = HttpStatus.OK, reason = "Random image generated and successfully stored") |
Contributor
There was a problem hiding this comment.
no need
Suggested change
| @ResponseStatus(code = HttpStatus.OK, reason = "Random image generated and successfully stored") |
Member
Author
There was a problem hiding this comment.
Nop, success isn't Exception
| } | ||
|
|
||
| @ResponseStatus(code = HttpStatus.OK, reason = "Random image generated and successfully stored") | ||
| @PostMapping("/generateRandomImage") |
Contributor
There was a problem hiding this comment.
Suggested change
| @PostMapping("/generateRandomImage") | |
| @PostMapping |
SamuelLevi
requested changes
Apr 28, 2019
mugshot/src/main/java/hive/mugshot/controller/MugshotController.java
Outdated
Show resolved
Hide resolved
mugshot/src/main/java/hive/mugshot/exception/InvalidPathException.java
Outdated
Show resolved
Hide resolved
SamuelLevi
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩
New things:
Changes:
Removed:
( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩( ᐛ )و ٩