Open
Conversation
The current implementation of _continuous, $x/k$ maps 0 to 0 and k to 1 which feels desirable. However, I beleive _discretize should be the inverse of _continuous which results in the current implementation of _discretize being $ceil(x*k - 0.5)$ which has "bins" of differing widths at the extremes (half the width of the internal bins). This does not feel right. The TODO notes describe a counter-proposal in which _discretize maps to constant-width bins but the inverse means that _continuous no longer maps 0 and k to 0 and 1 respectivley. This also feels wrong.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=======================================
Coverage 92.70% 92.70%
=======================================
Files 13 13
Lines 713 713
=======================================
Hits 661 661
Misses 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
henryrobbins
changed the title
Owner
Author
|
@dtorop This has been bothering me for awhile. Any thoughts? I had trouble finding the "right way" to do this because I didn't know which keywords to search for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of _continuous,$x/k$ maps 0 to 0 and k to 1 which
$ceil(x*k - 0.5)$ which has "bins" of differing widths at the extremes (half
feels desirable. However, I beleive _discretize should be the inverse of
_continuous which results in the current implementation of _discretize being
the width of the internal bins). This does not feel right. The TODO notes
describe a counter-proposal in which _discretize maps to constant-width bins
but the inverse means that _continuous no longer maps 0 and k to 0 and 1
respectivley. This also feels wrong.