Conversation
gndelia
reviewed
May 8, 2025
gndelia
reviewed
May 8, 2025
gndelia
reviewed
May 8, 2025
gndelia
reviewed
May 8, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the initial version of the project, including the code, documentation, tests, and configuration files necessary for sorting GitHub Actions YAML files.
- Adds various YAML fixture files for workflows and composite actions (both unsorted and sorted).
- Implements the core sorting functionality in JavaScript (src/index.js) based on a configuration defined in keys.json.
- Provides comprehensive configuration and CI/CD setup across multiple files (e.g. package.json, GitHub workflows, ESLint, Husky).
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/fixtures/workflow.yml | Unsorted workflow file fixture |
| test/fixtures/workflow-sorted.yml | Sorted workflow file fixture |
| test/fixtures/other.yml | A YAML file with an unusual structure that may not be valid |
| test/fixtures/action.yml | Unsorted composite action file with key order differing from guide |
| test/fixtures/action-sorted.yml | Sorted composite action file fixture |
| src/keys.json | Configuration for sorting rules |
| src/index.js | Sorting algorithm implementation using the YAML package |
| package.json | Project metadata and dependency configuration |
| README.md | Documentation on project purpose and usage |
| Other configuration files | Supporting CI/CD and dev tooling settings |
Comments suppressed due to low confidence (1)
test/fixtures/other.yml:3
- The structure in this file does not conform to a valid GitHub Actions workflow format. Please verify if this file is intended as an invalid fixture or update it to follow proper YAML structure.
- github:
ArturDolzan
previously approved these changes
May 9, 2025
gndelia
requested changes
May 9, 2025
gndelia
requested changes
May 9, 2025
gndelia
reviewed
May 9, 2025
rafappelt
previously approved these changes
May 22, 2025
ArturDolzan
approved these changes
May 28, 2025
gndelia
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the first version of everything in the repo. See the docs for more info. Not copying-pasting here!