Implementation of CILogon and Dex OIDC authentication sources.#397
Draft
PhillipsOwen wants to merge 21 commits intodevelopfrom
Draft
Implementation of CILogon and Dex OIDC authentication sources.#397PhillipsOwen wants to merge 21 commits intodevelopfrom
PhillipsOwen wants to merge 21 commits intodevelopfrom
Conversation
…into issue_396 # Conflicts: # appstore/appstore/settings/base.py
frostyfan109
changed the title
frostyfan109
reviewed
Feb 6, 2026
appstore/appstore/settings/base.py
Outdated
Comment on lines
14
to
33
| # SECURITY WARNING: don't run with debug turned on in production! | ||
| # Empty quotes equates to false in kubernetes env. | ||
| DEBUG_STRING = os.environ.get("DEBUG", "") | ||
| if DEBUG_STRING.lower() == "false": | ||
| DEBUG_STRING = "" | ||
|
|
||
| DEBUG = bool(DEBUG_STRING) | ||
|
|
||
| if DEBUG: | ||
| from product.configuration import ProductSettings, ProductColorScheme | ||
|
|
||
| APPLICATION_BRAND = os.environ.get("BRAND", "") | ||
|
|
||
| PRODUCT_SETTINGS = ProductSettings( | ||
| brand=APPLICATION_BRAND, | ||
| title=APPLICATION_BRAND, | ||
| logo_url=f"/static/images/{APPLICATION_BRAND}/logo.png", | ||
| color_scheme=ProductColorScheme("#191348", "#0079bc"), | ||
| links=None, | ||
| ) |
Contributor
There was a problem hiding this comment.
Needs to get removed or rewritten to actually address the underlying issue rather than patching it out in here
Author
There was a problem hiding this comment.
Local debugging stuff removed.
appstore/appstore/settings/base.py
Outdated
| for PROVIDER in OAUTH_PROVIDERS: | ||
| if PROVIDER != '': | ||
| THIRD_PARTY_APPS.append(f"allauth.socialaccount.providers.{PROVIDER}") | ||
| THIRD_PARTY_APPS.append("allauth.socialaccount.providers.openid_connect") |
Contributor
There was a problem hiding this comment.
Maybe should be added only when oidc is configured in the environment. Might be fine to always add it though. Needs confirmation
appstore/appstore/adapter.py
Outdated
Comment on lines
63
to
66
| def populate_user(self, request, sociallogin, data): | ||
| user = super().populate_user(request, sociallogin, data) | ||
| print('sociallogin.account.extra_data:', sociallogin.account.extra_data) | ||
| return user |
Contributor
There was a problem hiding this comment.
this is just debug at the moment. Needs to be fleshed out
Author
There was a problem hiding this comment.
commented out. this could be used in the future to discover what some SSOs are providing.
PhillipsOwen
changed the title
…into issue_396
…s bank that is used to declare a provider like Dex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add CILogon and Dex OIDC authentication methods