be more specific in comment in the helx-network-policy template#118
Open
pj-linebaugh wants to merge 1 commit intodevelopfrom
Open
be more specific in comment in the helx-network-policy template#118pj-linebaugh wants to merge 1 commit intodevelopfrom
pj-linebaugh wants to merge 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the comment in the network policy I added recently. Realized that it allows ingress traffic to all the pods in the namespace from the resty, ambassador, nginx, and appstore-sockets pods. This still works to block traffic between the app pods, but is more permissive than I thought. The network policy can be refined further by someone who knows what HeLx infra pods need to communicate with other HeLx infra pods and on what port.