add replicaset permission to apps group#114
Merged
frostyfan109 merged 5 commits intodevelopfrom Apr 9, 2025
Merged
Conversation
Collaborator
|
I trust your judgment on this and agree, I hate lots of logs and it's better to make the pvc deletion at present a manual process |
joshua-seals
reviewed
Apr 4, 2025
joshua-seals
approved these changes
Apr 4, 2025
Collaborator
joshua-seals
left a comment
There was a problem hiding this comment.
Pending update to the appVersion I approve this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tearing down a deployment, tycho attempts to wildcard delete all the following resources who have a
tycho-guid=<deployment_sid>label attached:deployment, replicaset, pod, persistentvolumeclaim. Pods and deployments already have deletecollection permission under the appstore service account role. However, neither replica sets nor PVCs have a deletecollection permission.Even when there are no replicasets/PVCs with the associated tycho-guid label, Tycho does a collection delete against the label for each resource, which requires the permission. Since the role lacks delete permission for both of these, it generates a lot of error logs during app termination even if there weren't any resources to delete anyways.
At the very least, we can mitigate the error logs for replicasets here, no harm done. However, I'd like input regarding whether or not we want to allow deletion of PVCs. I'd heavily lean towards no. If so, we should probably comment out the PVC collection delete in tycho (networkpolicy was also commented out at some point) instead of continuing to attempt the delete without permission.