Skip to content

Conversation

@hekt
Copy link
Owner

@hekt hekt commented Jul 11, 2025

Summary

  • use zsh builtin expansion to set FILE_DIR

Testing

  • pytest -q

https://chatgpt.com/codex/tasks/task_e_687071cab650832b814b29e92a21a9bb

@hekt hekt requested a review from Copilot July 11, 2025 02:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates how FILE_DIR is determined in the Zsh config, replacing an external cd/dirname call with a native Zsh parameter expansion to avoid issues in certain environments like VSCode.

  • Replaced legacy cd + dirname logic with ${${(%):-%N}:A:h} expansion.
  • Added comments explaining the switch to built-in path resolution.
Comments suppressed due to low confidence (1)

.config/zsh/zshrc:1

  • [nitpick] This comment refers to the old method. Update it to describe the new Zsh parameter expansion approach for resolving the file's directory.
# directory fullpath of this file

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@hekt hekt merged commit 8078542 into master Jul 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant