Add config parsing tests with CI #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds basic tests to verify that JSON and TOML configuration files can be parsed and sets up a GitHub Actions workflow to run these tests automatically.
- Introduces a pytest in
tests/test_configs.pythat loads Karabiner JSON and Starship TOML files. - Adds a new GitHub Actions workflow (
.github/workflows/test.yml) to install dependencies and run pytest on pull requests and pushes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_configs.py | New test to load and parse JSON and TOML config files |
| .github/workflows/test.yml | CI workflow to install Python dependencies and run tests |
| pull_request: | ||
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
The workflow is set to trigger on pushes to 'master', but the repository's default branch is 'main' (per your index). Update this to 'main' or use the default branch name to ensure CI runs as expected.
Suggested change
| - master | |
| - main |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit d87c57e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.config/karabiner/karabiner.jsonand.config/starship.tomlTesting
pytest -vhttps://chatgpt.com/codex/tasks/task_e_6843c1a65f10832badb61d0abc18efbf