fix: phase_test() now correctly ranks phases#17
Open
stephaniereinders wants to merge 1 commit intoheike:masterfrom
Open
fix: phase_test() now correctly ranks phases#17stephaniereinders wants to merge 1 commit intoheike:masterfrom
phase_test() now correctly ranks phases#17stephaniereinders wants to merge 1 commit intoheike:masterfrom
Conversation
Contributor
|
@heike I think this is a solid change, what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16. Changed the way that the helper data frames
avgsanddframeare calculated so that the highest rank is now correctly assigned to the phase with the highest mean. This, in turn, fixes thesigmasdata frame so that it now correctly labels the phase with the highest mean as in-phase.