Add Windows install and uninstall scripts #2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const targetPath = normalize(join(base, target)); | ||
| if (!targetPath.startsWith(base)) { | ||
| return base; | ||
| } | ||
| return targetPath; |
There was a problem hiding this comment.
Static asset requests currently get HTML because safeJoin is called with leading-slash pathnames (e.g. /styles.css), so join(publicDir, target) drops publicDir, targetPath.startsWith(publicDir) fails, and the function returns the directory. serveStatic then treats every request as a directory hit and falls back to index.html with text/html, meaning /styles.css or /assets/main.js are never served and the UI cannot load. Strip the leading slash or otherwise join paths so assets resolve under publicDir instead of always falling back to the SPA entry.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task