DPI Override in ElementProperties > PptxUnitHelper#75
Open
bekworks wants to merge 2 commits intoheavysixer:masterfrom
Open
DPI Override in ElementProperties > PptxUnitHelper#75bekworks wants to merge 2 commits intoheavysixer:masterfrom
bekworks wants to merge 2 commits intoheavysixer:masterfrom
Conversation
added 2 commits
April 23, 2021 13:30
Owner
|
@gregdolley this looks good to me, but see that this example is limited. what do you think it would take to make this more global? |
Owner
|
@bekworks Can you please add some unit tests for this to ensure we have good coverage and that future commits don't inadvertently break your code? |
Owner
|
@bekworks additionally what is the workflow you added? I see that your branch requires approval to run a workflow but am curious what that is and why its needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple override of default 72 DPI used in PptxUnitHelper.
Solves
Adding images into our PowerPoint template results in dimension overrides, in the form of scaling.
Our template is set at 96 DPI, resulting in a scaling of 133% of all inserted images, using the default DPI of 72.
This allows us to specifically set the targeted DPI when adding images, thus eliminating the scaling altogether.
Notes
This may be required for some other elements as well, shapes and textboxes, but I've left those alone, as we're not using them.
This was the easiest way to achieve our needs of not having to switch to a different library.
In a perfect world, the DPI settings should be read from the document, and automatically be used in calculations. But I do not have the required experience with PowerPoint, to actually achieve this.