Fix build with modern toolchains by including <cstdint> in rasterizer_impl.h#36
Open
filippocastelli wants to merge 1 commit intohbb1:mainfrom
Open
Fix build with modern toolchains by including <cstdint> in rasterizer_impl.h#36filippocastelli wants to merge 1 commit intohbb1:mainfrom
filippocastelli wants to merge 1 commit intohbb1:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cuda_rasterizer/rasterizer_impl.huses fixed-width integer types(
uint32_t,uint64_t) andstd::uintptr_t, but does not explicitlyinclude
<cstdint>(or<stdint.h>).Older toolchains compiled successfully due to indirect includes,
but recent environments (e.g. Ubuntu 24.04 + GCC 13 + CUDA 12.6)
fail with errors such as:
This patch adds
#include <cstdint>to make the header self-containedand restore compatibility with modern compilers.
std::uintptr_tand fixed-width integer types are defined in<cstdint>.Relying on transitive includes is not guaranteed by the standard.
This change does not alter behavior, ABI, or performance — it only
ensures correct compilation.
Tested on
Build succeeds after this change.