Profile picture uploading #41 #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
November 4, 2021 21:33
…on to extract Image data and update the previewImage
sundayezeilo
suggested changes
Nov 23, 2021
sundayezeilo
left a comment
sundayezeilo
left a comment
There was a problem hiding this comment.
Looks good. There are a few minor comments to fix, though. Please also remember to link your ticket in all your future PRs. See this guide
| return await fetch(`/imageUpload`, fetchOptions) | ||
| .then((res) => res.json()) | ||
| .catch((err) => { | ||
| console.log('UPLOADIMAGE-ERROR: ', err); |
There was a problem hiding this comment.
You can use console.error for this log
| onSubmit={handleSubmit} | ||
| encType="multipart/form-data" | ||
| > | ||
| <input |
| type="file" | ||
| onChange={handleChange} | ||
| /> | ||
| <label htmlFor="fileInput" className={classes.label}> |
| Upload a file from your device | ||
| </Button> | ||
| </label> | ||
| <button type="submit" className={classes.submitButton}></button> |
There was a problem hiding this comment.
Use MUI Button component for this one
| </form> | ||
| </Grid> | ||
| <Grid item container className={classes.deleteButtonContainer}> | ||
| {/*this is going to remove from the cloud*/} |
| alignItems: 'center', | ||
| justifyContent: 'center', | ||
| zIndex: -1, | ||
| // zIndex: -1, |
…console.log to console.err
Collaborator
Author
|
I've made the suggested changes above, in this commit 13f946a |
sundayezeilo
left a comment
sundayezeilo
left a comment
There was a problem hiding this comment.
Nice job making the requested changes 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does (required):
profile-photopage, to cloudinary via theuploadImageAPI Call.Any information needed to test this feature (required):
localhost:3000, and try to upload a photo using the upload button on the profile photo page. Please DM me if you would like the credentials to do so.Screenshots / Videos (front-end only)