Open
Conversation
… 1.2.1 This also silences all the "unsafe variable assignment" warnings.
Author
|
+1 |
1 similar comment
|
+1 |
|
It would also be appropriate to bump the minor version. |
Author
|
bump |
Author
Yes. I think it should happen after the PR is merged though. |
|
Bump |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am in the process of integrating server-side react rendering with a Phoenix application, and I couldn't use the latest release on hex.pm because of a dependency version conflict with Phoenix.
I'm following this guide:
http://blog.overstuffedgorilla.com/render-react-with-phoenix/
(and thanks for the great writeup!)
This PR updates the poison dependency to make the library compatible with Phoenix 1.2.1
This also silences all the "unsafe variable assignment" warnings.