Remove withSocketsDo from examples#596
Merged
kazu-yamamoto merged 1 commit intohaskell:masterfrom Jan 6, 2025
Merged
Conversation
- remove it from the examples - move documentation to the bottom of the module as most people won't need it
Contributor
Author
|
(Also moved its documentation to the bottom, as most people won't need it.) |
Collaborator
kazu-yamamoto
approved these changes
Jan 6, 2025
Collaborator
kazu-yamamoto
left a comment
kazu-yamamoto
left a comment
There was a problem hiding this comment.
Yes, it's time to remove it from the examples!
| sendBufTo, | ||
|
|
||
| -- * Initialisation on Windows | ||
| withSocketsDo, |
Collaborator
There was a problem hiding this comment.
This is a wrong position. It should be in front of where. I will fix this by myself.
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR set to draft because of question: should the function be removed entirely? As I understand it, the version where it's required (2.6.0.2) has it anyway, and the newer versions don't need it.