Add lifted version of Async.cancelMany #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isomorpheme
commented
Jul 15, 2025
|
|
||
| build-depends: base >= 4.14 && < 5 | ||
| , async >= 2.2.2 | ||
| , async >= 2.2.5 |
Contributor
Author
There was a problem hiding this comment.
I had to do this since cancelMany is only in async from this version. If that's undesirable I can look into making its definition conditional on the version, using CPP.
arybczak
reviewed
Jul 15, 2025
Member
arybczak
left a comment
arybczak
left a comment
There was a problem hiding this comment.
Thanks 👍 Please add a changelog entry "Add cancelMany to Effectful.Concurrent.Async".
|
|
||
| build-depends: base >= 4.14 && < 5 | ||
| , async >= 2.2.2 | ||
| , async >= 2.2.5 |
| cancel = unsafeEff_ . A.cancel | ||
|
|
||
| -- | Lifted 'A.cancelMany'. | ||
| cancelMany :: Concurrent :> es => [Async a] -> Eff es () |
Contributor
Author
There was a problem hiding this comment.
Indeed I forgot to export it! (Thankfully CI caught that too.)
isomorpheme
force-pushed
the
async-cancel-many
branch
from
bb093e2 to
8b27c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.