-
Notifications
You must be signed in to change notification settings - Fork 65
Made it possible to let the agent use system binaries if exists #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request enables the agent to use system binaries (e.g., 7zr, uftpd) if they exist in the system PATH, falling back to local binaries in the current working directory. This addresses issue #1052 by adding flexibility in binary location management.
Key changes:
- Introduced a new
retrieveBinaryfunction that prioritizes local binaries and falls back to system binaries - Replaced platform-specific (Windows/Linux) binary path logic with unified calls to
retrieveBinary - Simplified binary extraction commands by removing OS-specific conditional logic
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| htpclient/helpers.py | Added new retrieveBinary function to locate binaries from local directory or system PATH; updated start_uftpd to use this function |
| htpclient/files.py | Replaced OS-specific 7zr path logic with retrieveBinary call for file extraction |
| htpclient/binarydownload.py | Updated binary checks and extraction commands across multiple methods (prince, preprocessor, cracker version) to use retrieveBinary instead of OS-specific path logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
closes hashtopolis/server#1052