Add diagcheck package for testing deprecation warnings#619
Draft
Add diagcheck package for testing deprecation warnings#619
Conversation
Introduces a new diagcheck package that enables provider developers to test deprecation messages in acceptance tests. The package follows the established plancheck/statecheck pattern and integrates with terraform validate command. Key features: - DiagnosticCheck interface for validating terraform diagnostics - ExpectNoDiagnostics(), ExpectNoWarnings(), ExpectNoErrors() checks - ExpectDiagnostic() and ExpectWarning() for specific diagnostic assertions - ExpectDiagnosticCount() and ExpectWarningCount() for count validation - ConfigValidateChecks field on TestStep for validation-time checks - Validate() method on WorkingDir to execute terraform validate - 100% test coverage with 23 unit tests This addresses the need to test deprecation messages introduced across the Terraform plugin ecosystem (terraform-plugin-framework#1276, terraform-plugin-sdk#1553, terraform-core#38135). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new diagcheck package that enables provider developers to test
deprecation messages in acceptance tests. The package follows the established
plancheck/statecheck pattern and integrates with terraform validate command.
Key features:
This addresses the need to test deprecation messages introduced across the
Terraform plugin ecosystem (terraform-plugin-framework#1276,
terraform-plugin-sdk#1553, terraform-core#38135).
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Related Issue
Fixes #
Description
In plain English, describe your approach to addressing the issue linked above. For example, if you made a particular design decision, let us know why you chose this path instead of another solution.
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.