Skip to content

query: fix expect length query check by collecting all query summaries and matching on resource address#604

Merged
stephybun merged 3 commits intomainfrom
b/fix-expect-length-query-check
Feb 10, 2026
Merged

query: fix expect length query check by collecting all query summaries and matching on resource address#604
stephybun merged 3 commits intomainfrom
b/fix-expect-length-query-check

Conversation

@stephybun
Copy link
Member

Related Issue

Related to #597

Description

This is the first PR that addresses the problems outlined in #597 it does the following:

  • Introduces the QuerySummaries property to collect all available ListCompleteMessage, if there are multiple list blocks in the config then there are multiple ListCompleteMessage
  • Deprecated the QuerySummary property
  • Updated the behaviour of the ExpectLength query check to first match on the resource address before comparing the count
  • Duplicated the mock resource and list resource to add the examplecloud_bananette resource to cover additional test cases for this fix

Up Next:

  • A separate PR adding support for regex based matching to calculate counts from dynamically created list blocks
  • Updating the user facing documentation on query checks with the changes from this PR and the new check described in the point above

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

None

@stephybun stephybun requested a review from a team as a code owner February 9, 2026 08:42
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one question, the rest LGTM 👍🏻

@stephybun stephybun force-pushed the b/fix-expect-length-query-check branch from f449d63 to ca45fd3 Compare February 10, 2026 14:17
@stephybun stephybun merged commit 230f231 into main Feb 10, 2026
43 checks passed
@stephybun stephybun deleted the b/fix-expect-length-query-check branch February 10, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants