Open
Conversation
When running a black-box Packer test, crashes were to be detected automatically so that tests that crash are always reported as a failure. However, the match for detecting that Packer crashed was incorrectly formed, so those weren't detected.
Previous versions of the packerCommand implementation for wrapping a freshly compiled Packer binary to run tests with were a bit opaque, and printing out the logs from a run was defined in `Assert` as a plain checker, using a bit of a clumsy call that repeats already known information like `testing.T`. This commit changes the implementation so that `Dump` becomes a function call akin to the others, which doesn't need any parameter, instead it leverages what if already kept within the packerCommand structure.
In addition to dumping the results of a command, we also now dump the command itself, so we know exactly which command was invoked to produce the result we got.
lbajolet-hashicorp
added
the
tech-debt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dumping a command's results for black-box tests used to involve creating a checker, adding it to the Assert list, and running the command.
This was a bit verbose, and forced us to forward the testing.T instance to the checker so it could output it.
This PR changes how dumping a test's results work, by adding a
Dump()function to thepackerCommanddirectly, so we lighten the changes needed to have information on the command when troubleshooting/writing a test for Packer using this method.