Add "include_data_disks" option to control whether data disks are included in the image#142
Open
Jalle19 wants to merge 4 commits intohashicorp:mainfrom
Open
Add "include_data_disks" option to control whether data disks are included in the image#142Jalle19 wants to merge 4 commits intohashicorp:mainfrom
Jalle19 wants to merge 4 commits intohashicorp:mainfrom
Conversation
Since there is no way to correlate the disk IDs we get back from the DescribeInstances with the data disk definitions we have in our template, we can't selectively exclude data disks from the image. But at least this is better than nothing.
"default" annotation has no effect, so we need to use a data type that supports "true/false/unset"
Author
|
Switched to using a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #141
Enables e.g. the following use case:
I could not find a way to correlate the data disks as returned by the API with our template data disk definitions, so it's difficult if not impossible to selectively exclude data disks from the image. While a global option is not the most flexible, it at least solves the problem where you have a single data disk that you don't want to include in the image.
This PR includes parts of #133 and #135 so it can be applied cleanly some day.