Add Support for Block Labels when using mapstructure-to-hcl2#193
Open
aidan-mundy wants to merge 4 commits intomainfrom
Open
Add Support for Block Labels when using mapstructure-to-hcl2#193aidan-mundy wants to merge 4 commits intomainfrom
mapstructure-to-hcl2#193aidan-mundy wants to merge 4 commits intomainfrom
Conversation
3e4909a to
53be7d8
Compare
Contributor
JenGoldstrich
left a comment
There was a problem hiding this comment.
This is looking good to me Aidan! I think this approach makes sense to me, I think we should add testing for this in the existing units, like we talked about in slack I think it'd be good to have an example on your provisioners you're working on since that'd make manual testing of this super easy
We'll likely also want to update https://github.com/hashicorp/packer-plugin-scaffolding the scaffolding to have an example of this, but thats after this is released of course
cmd/packer-sdc/internal/mapstructure-to-hcl2/mapstructure-to-hcl2.go
Outdated
Show resolved
Hide resolved
9bd6c6b to
b46d9da
Compare
45ddb52 to
5119a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapstructure-to-hcl'mapstructure:"nameLabel" hcl:",label"'(except with "`" instead of "'")required:"true"struct tag. Fields including that struct tag that are parsed as Attributes will haveRequired: truein their AttributeSpec.