Skip to content

[WIP] [Project Solar / Phase 1 / Migration] Accordion "carbonization" #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
didoo wants to merge 243 commits into
base: project-solar/phase-1-main-feature-branch
Choose a base branch
from
Draft

[WIP] [Project Solar / Phase 1 / Migration] Accordion "carbonization" #3525

didoo wants to merge 243 commits into from

Conversation

@didoo
Copy link
Contributor

@didoo didoo commented Jan 29, 2026

📌 Summary

🛠️ Detailed description

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

didoo added 30 commits January 28, 2026 15:25
@didoo
TODO - added temporary file to main feature branch for phase 1
0bdd831
@didoo
added temporary changeset to feature branch for $modes support
ce3fd44
@didoo
TEMP - added $modes entry to color.palette.neutral-0
1a24b36
@didoo
refactored logic used to provide SD configuration per target
d39f063
@didoo
progress on logic for handling $modes - 1
5e2f7a0
@didoo
TEMP - added modes-testing tokens
314be8d
@didoo
TEMP - added expected-CSS-output files
a1fd074
@didoo
progress on logic for handling $modes - 2
ba01377
@didoo
added attributes/themeable transformation
c12e582
@didoo
progress on logic for handling $modes - 3
025065d
@didoo
progress on logic for handling $modes - 4
f5e690c
@didoo
TEMP generated temporary dist files for testing
2be2981 
sq
@didoo
TEMP - added examples of generated themed tokens
81705ac
@didoo
added logic to generate theming CSS files
25af12f
@didoo
REVERT - Removed modes-testing tokens
7b8385a
@didoo
removed modes-testing folder from compilation
45ff1f3
@didoo
added carbon-extracted reference in the source definitions
b0c4435
@didoo
TEMP - added $modes entries for some color and typography tokens, w…
a7e6cc3 
…ith references to Carbon tokens, for testing
@didoo
changed outputReferences to false (temporary) to bypass issue wit…
163aeaa 
…h missing references when using Carbon tokens with theming logic
@didoo
added commented code to build to use for debugging issue with missi…
7729745 
…ng references and filtering when theming is applied
@didoo
added two new themed tokens generated files, for Scss mixins and for …
3655eb3 
…combined strategies
@didoo
fixed issue with cds naming missing the g
1826759
@didoo
fixed some issues with how the “extra” themed CSS files were generated
d5ba9df
@didoo
TEMP - Re-generated tokens
8b44ea3
@didoo
REVERT - added examples of generated themed tokens
a4123bb 
This reverts commit 194b9fb.
@didoo
REVERT - added expected-CSS-output files
a75fa1a 
This reverts commit 7462def.
@didoo
fixed wrong check for existence of key in object (0 values would tr…
3e46738 
…igger an error, but they’re valid)
@didoo
added .hds-theme-light/dark and [data-hds-theme=“light/dark”] to …
5198518 
…generated CSS selectors

(later we may decide to remove them, but for the moment we need them for the showcase theming page to work in its current implementation)
@didoo
re-generated themed tokens
d6a4339
@didoo
updated generation of tokens’ CSS helpers to use CSS variables for `f…
95d251d 
…ont-weight` helpers
didoo and others added 18 commits January 28, 2026 18:45
@didoo
abstracted getSourceFromFileWithRootSelector
47b30c6
@didoo
implemented custom “CSS variables” format for theme tokens, with logi…
a2f9606 
…c to handle aliasing (outputReferences) and files splitting (“common” vs “themed”)
@didoo
abstracted DocsJson custom format to its own file
66c7275
@didoo
removed attributes/themeable custom transform (not needed anymore)
c20693e
@didoo
added validation for generated themed tokens (as SD custom action)
0ddc687
@didoo
small tweakings, cleanups and fixes
e763c0f
@didoo
TEMP - Add test tokens (to be removed in a follow-up revert commit)
a2f1777
@didoo
Revert "TEMP - Add test tokens (to be removed in a follow-up revert…
096a346 
… commit)"

This reverts commit 455d9ec.
@didoo
[Project Solar / Phase 1 / Engineering Follow-ups] Converted tests fo…
352a365 
…r `HdsThemeSwitcher` and `HdsThemeContext` to `.gts` format (#3447)
@alex-ju @didoo
Refactor dist CSS file checks into script (#3462)
872c7e8
@didoo
re-generated all the dist and public files after rebasing on main
f7c4e59
@didoo
small cleanup of initial commits used to open the PR
91182a0
@didoo
[07a] [Project Solar / Phase 1] Include IBM Plex fonts as part of the…
0bb0d65 
… `@hashicorp/design-system-components` package (#3387)
@didoo
removed service which was not used
dd81a70
@didoo
re-generated public CSS files for components in Showcase after rebase
ba61b59
@didoo
implemented “carbonization” page for Accordion component
b016040
@didoo
updated Accordion styles to use new component-level design tokens
eb84f71
@didoo
added $modes values to some accordion tokens
c57203f
@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Jan 29, 2026 9:55pm
hds-website Ready Ready Preview Jan 29, 2026 9:55pm

Request Review

@didoo didoo force-pushed the project-solar/phase-1-main-feature-branch branch 8 times, most recently from d862a2e to ed96032 Compare February 10, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

packages/components packages/tokens showcase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@didoo @hashibot-hds @RobbieTheWagner @alex-ju